Added a test that sjtc correctly aborts on violation of constraints #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Tests succeed -> ready for review. Please note: I had to raise the limit of allowed deviation, as the implementation on Humble seems to not stop as fast as the one from Rolling. Do you think we should look into this in this PR or move that to a follow-up PR? |
This was referenced Sep 21, 2023
urmahp
approved these changes
Sep 21, 2023
fmauch
force-pushed
the
update_sjtc_humble
branch
from
070d441 to
789de22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Humble backport of #810. Since the JTC api changed on rolling recently, a direct backport isn't really applicable.